Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DACs to support PID/VID verfification #14845

Merged
merged 21 commits into from
Feb 9, 2022
Merged

Add DACs to support PID/VID verfification #14845

merged 21 commits into from
Feb 9, 2022

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Feb 7, 2022

Problem

#14551 introduced code to check that the VID and PID supplied by devices from the basic information cluster match the VID and PID specified in the attestation certificate.

Unfortunately, for almost all platforms, it didn't. The DAC being supplied was specific to VID 0xFFF1 and PID 0x8000 and almost none of the platform examples were using this.

As it is nice to be able to at least differentiate between examples, we have opted to allow examples to select a PID from withing a defined range and update the certificates to support this. All example code now uses VID 0xFFF1 and PID in the range of 0x8000-0x801F (which can be trivially updated to allow additional PIDs up to 0x8063).

Reviewers: Because there were a lot of cert files added and because there were a lot of fairly minor PID changes, it may be easier to review the individual commits in the PR. #14551 was previously approved and was reverted in order to wait for this PR to land.

Change overview

  • update PAI to not specify PID and use VID (PAI remains signed by test PAA)
  • Add DACs for VID 0xFFF1 PIDs 0x8000-0x801F
  • Update Example credential issuer to select DAC based on the PID specified in the confi
  • Update VID and PIDs for all platform implementation to match the PID list given
  • Update tests to support the use of the new example issuer by hardcoding known good values in the tests.
  • Add PEM and DER files for all the new certs
  • un-revert Check VID/PID when doing device attestation #14551

Testing

Tested by CI, unit tests

  • tested on linux and M5 using new x8001 PID. Tested on M5 with PID forced to 0x8002.

@cecille
Add new certs for development.
1dda7ba 
We are moving to have the certificate verification check the VID and PID
between the basic cluster and the DAC/CD. Right now, none of the examples
pass prorperly because the VIDs and PIDs do not match. In order to
facilitate development while platforms are developing their own
DeviceAttestationCredentialsProvider, we have provided a new set of
development certs that can be used for development only.

This new scheme is backed by the test PAA in attestation/test/. This was
done to reduce the number of changes required to the controllers, which
already contain this PAA in their trusted certs.

The PAI has been changed to omit the PID. This means the we can use a
common PAI cert for all products. The vendor ID for the PAI is 0xFFF1,
which a known test vendor for Matter.

The DACs below are signed by the new PAI and include certs and keys
for PIDs 0x8000-0x801F.
@cecille
Use new certificates in attestation.
5568fef 
Test: Can commission linux lighting app using pid 0x8000
@cecille
Add new certificate declaration
d0c0a93 
This new CD will veryify against all products with VID 0xFFF1
and PIDs in the range of 0x8000-0x8063.

Test: Verified on linux lighitng app by forcing app and controller
      to use pid 0x8001
@cecille
Update example PIDs.
cdf4eaf 
Please see documentation in docs/examples.
@cecille
Add explicit warning for PID/VID mismatch.
3c5fbfd
@cecille
Revert "Revert "Check VID/PID when doing device attestation (project-…
833edaa 
…chip#14551)" (project-chip#14795)"

This reverts commit ad28f32.
@cecille
Fix tests
50dcf67 
Use hard coded cert values for tests rather than going through the
example creds provider.
@boring-cyborg boring-cyborg bot added the config label Feb 7, 2022
@restyled-io restyled-io bot mentioned this pull request Feb 7, 2022
Closed
@cecille cecille changed the title Dac fixup for pid vid change Add DACs to support PID/VID verfification Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022 •
edited
Loading

PR #14845: Size comparison from d5d9dc7 to 50dcf67

Increases above 0.2%:

platform target config section d5d9dc7 50dcf67 change % change
cyw30739 light cyw930739m2evb_01 .data 624 648 24 3.8
lock cyw930739m2evb_01 .data 588 612 24 4.1
ota-requestor cyw930739m2evb_01 .data 532 556 24 4.5
efr32 lighting-app BRD4161A .data 1924 1948 24 1.2
BRD4161A+rpc .data 2024 2048 24 1.2
window-app BRD4161A .data 1880 1904 24 1.3
k32w light k32w061+release .data 1884 1908 24 1.3
lock k32w061+release .data 1924 1948 24 1.2
linux chip-tool-ipv6only arm64 .data 1176 1224 48 4.1
thermostat-no-ble arm64 .data 968 1016 48 5.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5296 5320 24 0.5
lighting-app CY8CPROTO_062_4343W+release .data 5600 5624 24 0.4
lock-app CY8CPROTO_062_4343W+release .data 5584 5608 24 0.4
shell CY8CPROTO_062_4343W+release .data 5400 5424 24 0.4
qpg lighting-app qpg6105+debug .data 1088 1112 24 2.2
lock-app qpg6105+debug .data 1024 1048 24 2.3
Increases (19 builds for cyw30739, efr32, esp32, k32w, linux, mbed, qpg, telink)
platform target config section d5d9dc7 50dcf67 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587734 588054 320 0.1
.app_xip_area 494468 494764 296 0.1
.data 624 648 24 3.8
lock cyw930739m2evb_01 (read/write) 545646 545962 316 0.1
.app_xip_area 453940 454232 292 0.1
.data 588 612 24 4.1
ota-requestor cyw930739m2evb_01 (read/write) 570090 570406 316 0.1
.app_xip_area 469064 469356 292 0.1
.data 532 556 24 4.5
efr32 lighting-app BRD4161A (read only) 857524 857804 280 0.0
(read/write) 125740 125764 24 0.0
.data 1924 1948 24 1.2
.text 857516 857796 280 0.0
BRD4161A+rpc (read only) 844900 845180 280 0.0
(read/write) 142400 142424 24 0.0
.data 2024 2048 24 1.2
.text 844892 845172 280 0.0
window-app BRD4161A (read only) 829776 830056 280 0.0
(read/write) 124384 124408 24 0.0
.data 1880 1904 24 1.3
.text 829768 830048 280 0.0
esp32 all-clusters-app c3devkit (read/write) 1401242 1401522 280 0.0
.flash.rodata 198000 198296 296 0.1
m5stack (read only) 985011 985023 12 0.0
(read/write) 465592 465880 288 0.1
.dram0.data 34040 34064 24 0.1
.flash.rodata 224608 224872 264 0.1
.flash.text 979627 979639 12 0.0
k32w light k32w061+release (read/write) 672292 672612 320 0.0
.data 1884 1908 24 1.3
.text 588920 589216 296 0.1
lock k32w061+release (read/write) 673760 674080 320 0.0
.data 1924 1948 24 1.2
.text 590020 590316 296 0.1
linux chip-tool-ipv6only arm64 (read only) 7239492 7242244 2752 0.0
.data 1176 1224 48 4.1
.rodata 392780 393180 400 0.1
.text 6241876 6244260 2384 0.0
thermostat-no-ble arm64 (read only) 2127652 2127972 320 0.0
.data 968 1016 48 5.0
.rodata 131412 131700 288 0.2
.text 1778288 1778352 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2389200 2389464 264 0.0
.data 5296 5320 24 0.5
.text 1351800 1352064 264 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2348464 2348728 264 0.0
.data 5600 5624 24 0.4
.text 1311064 1311328 264 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2312384 2312712 328 0.0
.data 5584 5608 24 0.4
.text 1274984 1275312 328 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2302836 2303100 264 0.0
.data 5400 5424 24 0.4
.text 1265408 1265672 264 0.0
qpg lighting-app qpg6105+debug (read only) 580504 580796 292 0.1
.data 1088 1112 24 2.2
.text 575184 575476 292 0.1
lock-app qpg6105+debug (read only) 526572 526856 284 0.1
.data 1024 1048 24 2.3
.text 521252 521536 284 0.1
telink lighting-app tlsr9518adk80d (read/write) 859166 859450 284 0.0
Decreases (4 builds for esp32, linux, telink)
platform target config section d5d9dc7 50dcf67 change % change
esp32 all-clusters-app c3devkit (read only) 937038 937034 -4 -0.0
.dram0.data 14276 14268 -8 -0.1
.flash.text 937038 937034 -4 -0.0
linux chip-tool-ipv6only arm64 (read/write) 287921 287905 -16 -0.0
.data.rel.ro 186528 186464 -64 -0.0
thermostat-no-ble arm64 (read/write) 140561 140545 -16 -0.0
.data.rel.ro 74872 74808 -64 -0.1
telink lighting-app tlsr9518adk80d text 602234 602232 -2 -0.0
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, qpg, telink)
platform target config section d5d9dc7 50dcf67 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587734 588054 320 0.1
.app_xip_area 494468 494764 296 0.1
.bss 75988 75988 0 0.0
.data 624 648 24 3.8
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545646 545962 316 0.1
.app_xip_area 453940 454232 292 0.1
.bss 74460 74460 0 0.0
.data 588 612 24 4.1
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570090 570406 316 0.1
.app_xip_area 469064 469356 292 0.1
.bss 83452 83452 0 0.0
.data 532 556 24 4.5
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857524 857804 280 0.0
(read/write) 125740 125764 24 0.0
.bss 123816 123816 0 0.0
.data 1924 1948 24 1.2
.text 857516 857796 280 0.0
BRD4161A+rpc (read only) 844900 845180 280 0.0
(read/write) 142400 142424 24 0.0
.bss 140376 140376 0 0.0
.data 2024 2048 24 1.2
.text 844892 845172 280 0.0
window-app BRD4161A (read only) 829776 830056 280 0.0
(read/write) 124384 124408 24 0.0
.bss 122504 122504 0 0.0
.data 1880 1904 24 1.3
.text 829768 830048 280 0.0
esp32 all-clusters-app c3devkit (read only) 937038 937034 -4 -0.0
(read/write) 1401242 1401522 280 0.0
.dram0.bss 70064 70064 0 0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 198000 198296 296 0.1
.flash.text 937038 937034 -4 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 985011 985023 12 0.0
(read/write) 465592 465880 288 0.1
.dram0.bss 74816 74816 0 0.0
.dram0.data 34040 34064 24 0.1
.flash.rodata 224608 224872 264 0.1
.flash.text 979627 979639 12 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 672292 672612 320 0.0
.bss 75688 75688 0 0.0
.data 1884 1908 24 1.3
.text 588920 589216 296 0.1
lock k32w061+release (read/write) 673760 674080 320 0.0
.bss 76016 76016 0 0.0
.data 1924 1948 24 1.2
.text 590020 590316 296 0.1
linux chip-tool-ipv6only arm64 (read only) 7239492 7242244 2752 0.0
(read/write) 287921 287905 -16 -0.0
.bss 50641 50641 0 0.0
.data 1176 1224 48 4.1
.data.rel.ro 186528 186464 -64 -0.0
.dynamic 560 560 0 0.0
.got 45784 45784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392780 393180 400 0.1
.text 6241876 6244260 2384 0.0
thermostat-no-ble arm64 (read only) 2127652 2127972 320 0.0
(read/write) 140561 140545 -16 -0.0
.bss 57601 57601 0 0.0
.data 968 1016 48 5.0
.data.rel.ro 74872 74808 -64 -0.1
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131412 131700 288 0.2
.text 1778288 1778352 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389200 2389464 264 0.0
.bss 188972 188972 0 0.0
.data 5296 5320 24 0.5
.text 1351800 1352064 264 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348464 2348728 264 0.0
.bss 180936 180936 0 0.0
.data 5600 5624 24 0.4
.text 1311064 1311328 264 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312384 2312712 328 0.0
.bss 180824 180824 0 0.0
.data 5584 5608 24 0.4
.text 1274984 1275312 328 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302836 2303100 264 0.0
.bss 178100 178100 0 0.0
.data 5400 5424 24 0.4
.text 1265408 1265672 264 0.0
qpg lighting-app qpg6105+debug (read only) 580504 580796 292 0.1
(read/write) 146940 146940 0 0.0
.bss 87976 87976 0 0.0
.data 1088 1112 24 2.2
.text 575184 575476 292 0.1
lock-app qpg6105+debug (read only) 526572 526856 284 0.1
(read/write) 146940 146940 0 0.0
.bss 87424 87424 0 0.0
.data 1024 1048 24 2.3
.text 521252 521536 284 0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859166 859450 284 0.0
bss 88332 88332 0 0.0
noinit 37160 37160 0 0.0
text 602234 602232 -2 -0.0

@emargolis
Copy link
Contributor

Might be a good idea to add the script that was used to generate all these certificates?

bzbarsky-apple
bzbarsky-apple approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit I did not verify that all the byte arrays and certificates are correct in any sense....

src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Outdated Show resolved Hide resolved
@jmartinez-silabs
Copy link
Member

Do we currently have a tool to generate the certificates for a given "parameters" set ?

@cecille
Copy link
Contributor Author

cecille commented Feb 7, 2022

I will add the script that was used to generate the certs in a new PR. It needs a bit of cleanup .

@github-actions
Copy link

github-actions bot commented Feb 7, 2022 •
edited
Loading

PR #14845: Size comparison from 6f9fa8e to 4710a0c

Increases above 0.2%:

platform target config section 6f9fa8e 4710a0c change % change
cyw30739 light cyw930739m2evb_01 .data 624 648 24 3.8
lock cyw930739m2evb_01 .data 588 612 24 4.1
ota-requestor cyw930739m2evb_01 .data 532 556 24 4.5
efr32 lighting-app BRD4161A .data 1924 1948 24 1.2
BRD4161A+rpc .data 2024 2048 24 1.2
window-app BRD4161A .data 1880 1904 24 1.3
k32w light k32w061+release .data 1884 1908 24 1.3
lock k32w061+release .data 1924 1948 24 1.2
linux chip-tool-ipv6only arm64 .data 1176 1224 48 4.1
thermostat-no-ble arm64 .data 968 1016 48 5.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5296 5320 24 0.5
lighting-app CY8CPROTO_062_4343W+release .data 5600 5624 24 0.4
lock-app CY8CPROTO_062_4343W+release .data 5584 5608 24 0.4
shell CY8CPROTO_062_4343W+release .data 5400 5424 24 0.4
nrfconnect lighting-app nrf52840dk_nrf52840+rpc rodata 109532 109812 280 0.3
lock-app nrf5340dk_nrf5340_cpuapp rodata 99644 99904 260 0.3
qpg lighting-app qpg6105+debug .data 1088 1112 24 2.2
lock-app qpg6105+debug .data 1024 1048 24 2.3
Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 6f9fa8e 4710a0c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594518 594838 320 0.1
.app_xip_area 500372 500668 296 0.1
.data 624 648 24 3.8
lock cyw930739m2evb_01 (read/write) 552422 552738 316 0.1
.app_xip_area 459836 460128 292 0.1
.data 588 612 24 4.1
ota-requestor cyw930739m2evb_01 (read/write) 576462 576778 316 0.1
.app_xip_area 474556 474848 292 0.1
.data 532 556 24 4.5
efr32 lighting-app BRD4161A (read only) 865884 866164 280 0.0
(read/write) 126620 126644 24 0.0
.data 1924 1948 24 1.2
.text 865876 866156 280 0.0
BRD4161A+rpc (read only) 853356 853636 280 0.0
(read/write) 143280 143304 24 0.0
.data 2024 2048 24 1.2
.text 853348 853628 280 0.0
window-app BRD4161A (read only) 838104 838384 280 0.0
(read/write) 125264 125288 24 0.0
.data 1880 1904 24 1.3
.text 838096 838376 280 0.0
esp32 all-clusters-app c3devkit (read/write) 1400986 1401266 280 0.0
.flash.rodata 198352 198648 296 0.1
m5stack (read only) 985307 985323 16 0.0
(read/write) 465320 465608 288 0.1
.dram0.data 34040 34064 24 0.1
.flash.rodata 224952 225216 264 0.1
.flash.text 979923 979939 16 0.0
k32w light k32w061+release (read/write) 678648 678968 320 0.0
.data 1884 1908 24 1.3
.text 594396 594692 296 0.0
lock k32w061+release (read/write) 680532 680836 304 0.0
.data 1924 1948 24 1.2
.text 595912 596192 280 0.0
linux chip-tool-ipv6only arm64 (read only) 7263300 7266100 2800 0.0
.data 1176 1224 48 4.1
.rodata 393132 393596 464 0.1
.text 6264276 6266644 2368 0.0
thermostat-no-ble arm64 (read only) 2129316 2129636 320 0.0
.data 968 1016 48 5.0
.rodata 131860 132148 288 0.2
.text 1779504 1779568 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2389760 2390024 264 0.0
.data 5296 5320 24 0.5
.text 1352360 1352624 264 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2348928 2349256 328 0.0
.data 5600 5624 24 0.4
.text 1311528 1311856 328 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2312848 2313176 328 0.0
.data 5584 5608 24 0.4
.text 1275448 1275776 328 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2302884 2303148 264 0.0
.data 5400 5424 24 0.4
.text 1265456 1265720 264 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004827 1005163 336 0.0
rodata 118072 118352 280 0.2
text 686540 686568 28 0.0
nrf52840dk_nrf52840+rpc (read/write) 976319 976655 336 0.0
rodata 109532 109812 280 0.3
text 671188 671216 28 0.0
nrf52840dongle_nrf52840 (read/write) 1021647 1021967 320 0.0
rodata 116960 117224 264 0.2
text 692112 692140 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 911506 911822 316 0.0
rodata 111332 111592 260 0.2
text 601568 601596 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 937083 937399 316 0.0
rodata 106472 106732 260 0.2
text 632460 632488 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844594 844894 300 0.0
rodata 99644 99904 260 0.3
text 548260 548288 28 0.0
pump-app nrf52840dk_nrf52840 (read/write) 939331 939647 316 0.0
rodata 106656 106916 260 0.2
text 634704 634736 32 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934671 934987 316 0.0
rodata 105948 106208 260 0.2
text 630740 630772 32 0.0
qpg lighting-app qpg6105+debug (read only) 585960 586252 292 0.0
.data 1088 1112 24 2.2
.text 580640 580932 292 0.1
lock-app qpg6105+debug (read only) 532028 532320 292 0.1
.data 1024 1048 24 2.3
.text 526708 527000 292 0.1
telink lighting-app tlsr9518adk80d (read/write) 865822 866106 284 0.0
Decreases (4 builds for esp32, linux, telink)
platform target config section 6f9fa8e 4710a0c change % change
esp32 all-clusters-app c3devkit (read only) 937480 937476 -4 -0.0
.dram0.data 14276 14268 -8 -0.1
.flash.text 937480 937476 -4 -0.0
linux chip-tool-ipv6only arm64 (read/write) 288385 288369 -16 -0.0
.data.rel.ro 186872 186808 -64 -0.0
thermostat-no-ble arm64 (read/write) 140625 140609 -16 -0.0
.data.rel.ro 74872 74808 -64 -0.1
telink lighting-app tlsr9518adk80d text 607738 607736 -2 -0.0
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 6f9fa8e 4710a0c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594518 594838 320 0.1
.app_xip_area 500372 500668 296 0.1
.bss 76868 76868 0 0.0
.data 624 648 24 3.8
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552422 552738 316 0.1
.app_xip_area 459836 460128 292 0.1
.bss 75340 75340 0 0.0
.data 588 612 24 4.1
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576462 576778 316 0.1
.app_xip_area 474556 474848 292 0.1
.bss 84332 84332 0 0.0
.data 532 556 24 4.5
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 865884 866164 280 0.0
(read/write) 126620 126644 24 0.0
.bss 124696 124696 0 0.0
.data 1924 1948 24 1.2
.text 865876 866156 280 0.0
BRD4161A+rpc (read only) 853356 853636 280 0.0
(read/write) 143280 143304 24 0.0
.bss 141256 141256 0 0.0
.data 2024 2048 24 1.2
.text 853348 853628 280 0.0
window-app BRD4161A (read only) 838104 838384 280 0.0
(read/write) 125264 125288 24 0.0
.bss 123384 123384 0 0.0
.data 1880 1904 24 1.3
.text 838096 838376 280 0.0
esp32 all-clusters-app c3devkit (read only) 937480 937476 -4 -0.0
(read/write) 1400986 1401266 280 0.0
.dram0.bss 69448 69448 0 0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 198352 198648 296 0.1
.flash.text 937480 937476 -4 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 985307 985323 16 0.0
(read/write) 465320 465608 288 0.1
.dram0.bss 74200 74200 0 0.0
.dram0.data 34040 34064 24 0.1
.flash.rodata 224952 225216 264 0.1
.flash.text 979923 979939 16 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 678648 678968 320 0.0
.bss 76568 76568 0 0.0
.data 1884 1908 24 1.3
.text 594396 594692 296 0.0
lock k32w061+release (read/write) 680532 680836 304 0.0
.bss 76896 76896 0 0.0
.data 1924 1948 24 1.2
.text 595912 596192 280 0.0
linux chip-tool-ipv6only arm64 (read only) 7263300 7266100 2800 0.0
(read/write) 288385 288369 -16 -0.0
.bss 50641 50641 0 0.0
.data 1176 1224 48 4.1
.data.rel.ro 186872 186808 -64 -0.0
.dynamic 560 560 0 0.0
.got 45904 45904 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 393132 393596 464 0.1
.text 6264276 6266644 2368 0.0
thermostat-no-ble arm64 (read only) 2129316 2129636 320 0.0
(read/write) 140625 140609 -16 -0.0
.bss 57665 57665 0 0.0
.data 968 1016 48 5.0
.data.rel.ro 74872 74808 -64 -0.1
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131860 132148 288 0.2
.text 1779504 1779568 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389760 2390024 264 0.0
.bss 188356 188356 0 0.0
.data 5296 5320 24 0.5
.text 1352360 1352624 264 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348928 2349256 328 0.0
.bss 180936 180936 0 0.0
.data 5600 5624 24 0.4
.text 1311528 1311856 328 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312848 2313176 328 0.0
.bss 180824 180824 0 0.0
.data 5584 5608 24 0.4
.text 1275448 1275776 328 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302884 2303148 264 0.0
.bss 178100 178100 0 0.0
.data 5400 5424 24 0.4
.text 1265456 1265720 264 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004827 1005163 336 0.0
bss 121280 121280 0 0.0
rodata 118072 118352 280 0.2
text 686540 686568 28 0.0
nrf52840dk_nrf52840+rpc (read/write) 976319 976655 336 0.0
bss 117136 117136 0 0.0
rodata 109532 109812 280 0.3
text 671188 671216 28 0.0
nrf52840dongle_nrf52840 (read/write) 1021647 1021967 320 0.0
bss 122644 122644 0 0.0
rodata 116960 117224 264 0.2
text 692112 692140 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 911506 911822 316 0.0
bss 117840 117840 0 0.0
rodata 111332 111592 260 0.2
text 601568 601596 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 937083 937399 316 0.0
bss 119616 119616 0 0.0
rodata 106472 106732 260 0.2
text 632460 632488 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844594 844894 300 0.0
bss 116212 116212 0 0.0
rodata 99644 99904 260 0.3
text 548260 548288 28 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 939331 939647 316 0.0
bss 119368 119368 0 0.0
rodata 106656 106916 260 0.2
text 634704 634736 32 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934671 934987 316 0.0
bss 119372 119372 0 0.0
rodata 105948 106208 260 0.2
text 630740 630772 32 0.0
shell nrf52840dk_nrf52840 (read/write) 803343 803343 0 0.0
bss 111232 111232 0 0.0
rodata 78532 78532 0 0.0
text 536004 536004 0 0.0
qpg lighting-app qpg6105+debug (read only) 585960 586252 292 0.0
(read/write) 146940 146940 0 0.0
.bss 88856 88856 0 0.0
.data 1088 1112 24 2.2
.text 580640 580932 292 0.1
lock-app qpg6105+debug (read only) 532028 532320 292 0.1
(read/write) 146940 146940 0 0.0
.bss 88304 88304 0 0.0
.data 1024 1048 24 2.3
.text 526708 527000 292 0.1
persistent-storage-app qpg6105+debug (read only) 99548 99548 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94228 94228 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 865822 866106 284 0.0
bss 88592 88592 0 0.0
noinit 37160 37160 0 0.0
text 607738 607736 -2 -0.0

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR #14845: Size comparison from 52d0b42 to 689bcfa

Increases above 0.2%:

platform target config section 52d0b42 689bcfa change % change
cyw30739 light cyw930739m2evb_01 .data 624 648 24 3.8
lock cyw930739m2evb_01 (read/write) 553262 556646 3384 0.6
.app_xip_area 460356 463692 3336 0.7
.data 588 612 24 4.1
ota-requestor cyw930739m2evb_01 .data 532 556 24 4.5
efr32 lighting-app BRD4161A .data 1924 1948 24 1.2
BRD4161A+rpc .data 2024 2048 24 1.2
window-app BRD4161A .data 1880 1904 24 1.3
k32w light k32w061+release .data 1884 1908 24 1.3
lock k32w061+release (read/write) 681080 684316 3236 0.5
.data 1924 1952 28 1.5
.text 596396 599580 3184 0.5
linux chip-tool-ipv6only arm64 .data 1176 1224 48 4.1
thermostat-no-ble arm64 .data 984 1032 48 4.9
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5304 5328 24 0.5
lighting-app CY8CPROTO_062_4343W+release .data 5600 5624 24 0.4
lock-app CY8CPROTO_062_4343W+release .data 5584 5608 24 0.4
.text 1275968 1280272 4304 0.3
shell CY8CPROTO_062_4343W+release .data 5400 5424 24 0.4
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 118268 118544 276 0.2
nrf52840dk_nrf52840+rpc rodata 109656 109916 260 0.2
nrf52840dongle_nrf52840 rodata 117156 117416 260 0.2
nrf5340dk_nrf5340_cpuapp rodata 111524 111784 260 0.2
lock-app nrf52840dk_nrf52840 (read/write) 937663 940915 3252 0.3
rodata 106668 107752 1084 1.0
text 632844 634860 2016 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 845234 848394 3160 0.4
rodata 99836 100924 1088 1.1
text 548644 550660 2016 0.4
pump-app nrf52840dk_nrf52840 rodata 106848 107112 264 0.2
pump-controller-app nrf52840dk_nrf52840 rodata 106140 106404 264 0.2
qpg lighting-app qpg6105+debug .data 1084 1108 24 2.2
lock-app qpg6105+debug (read only) 532420 535616 3196 0.6
.data 1024 1052 28 2.7
.text 527100 530296 3196 0.6
Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 52d0b42 689bcfa change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595378 595698 320 0.1
.app_xip_area 500912 501208 296 0.1
.data 624 648 24 3.8
lock cyw930739m2evb_01 (read/write) 553262 556646 3384 0.6
.app_xip_area 460356 463692 3336 0.7
.bss 75660 75684 24 0.0
.data 588 612 24 4.1
ota-requestor cyw930739m2evb_01 (read/write) 577294 577610 316 0.1
.app_xip_area 475068 475360 292 0.1
.data 532 556 24 4.5
efr32 lighting-app BRD4161A (read only) 866356 866636 280 0.0
(read/write) 126684 126708 24 0.0
.data 1924 1948 24 1.2
.text 866348 866628 280 0.0
BRD4161A+rpc (read only) 853804 854084 280 0.0
(read/write) 143344 143368 24 0.0
.data 2024 2048 24 1.2
.text 853796 854076 280 0.0
window-app BRD4161A (read only) 838560 838840 280 0.0
(read/write) 125328 125352 24 0.0
.data 1880 1904 24 1.3
.text 838552 838832 280 0.0
esp32 all-clusters-app c3devkit (read/write) 1402434 1402714 280 0.0
.flash.rodata 199208 199504 296 0.1
m5stack (read only) 987139 987151 12 0.0
(read/write) 467444 467732 288 0.1
.dram0.data 34040 34064 24 0.1
.flash.rodata 226100 226364 264 0.1
.flash.text 981755 981767 12 0.0
k32w light k32w061+release (read/write) 679180 679500 320 0.0
.data 1884 1908 24 1.3
.text 594864 595160 296 0.0
lock k32w061+release (read/write) 681080 684316 3236 0.5
.bss 76960 76984 24 0.0
.data 1924 1952 28 1.5
.text 596396 599580 3184 0.5
linux chip-tool-ipv6only arm64 (read only) 7409244 7412124 2880 0.0
.data 1176 1224 48 4.1
.rodata 399300 399780 480 0.1
.text 6370452 6372884 2432 0.0
thermostat-no-ble arm64 (read only) 2134876 2135212 336 0.0
.data 984 1032 48 4.9
.rodata 132316 132604 288 0.2
.text 1784400 1784464 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2391184 2391512 328 0.0
.data 5304 5328 24 0.5
.text 1353784 1354112 328 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2349448 2349712 264 0.0
.data 5600 5624 24 0.4
.text 1312048 1312312 264 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2313368 2317672 4304 0.2
.bss 180888 180912 24 0.0
.data 5584 5608 24 0.4
.text 1275968 1280272 4304 0.3
shell CY8CPROTO_062_4343W+release (read/write) 2303340 2303668 328 0.0
.data 5400 5424 24 0.4
.text 1265912 1266240 328 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005423 1005739 316 0.0
rodata 118268 118544 276 0.2
text 686928 686956 28 0.0
nrf52840dk_nrf52840+rpc (read/write) 974379 974695 316 0.0
rodata 109656 109916 260 0.2
text 666540 666568 28 0.0
nrf52840dongle_nrf52840 (read/write) 1022227 1022543 316 0.0
rodata 117156 117416 260 0.2
text 692496 692524 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 912146 912462 316 0.0
rodata 111524 111784 260 0.2
text 601952 601980 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 937663 940915 3252 0.3
bss 119680 119712 32 0.0
rodata 106668 107752 1084 1.0
text 632844 634860 2016 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 845234 848394 3160 0.4
bss 116276 116304 28 0.0
rodata 99836 100924 1088 1.1
text 548644 550660 2016 0.4
pump-app nrf52840dk_nrf52840 (read/write) 940035 940355 320 0.0
rodata 106848 107112 264 0.2
text 635088 635120 32 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935375 935695 320 0.0
rodata 106140 106404 264 0.2
text 631124 631156 32 0.0
qpg lighting-app qpg6105+debug (read only) 586368 586652 284 0.0
.data 1084 1108 24 2.2
.text 581048 581332 284 0.0
lock-app qpg6105+debug (read only) 532420 535616 3196 0.6
.bss 88368 88392 24 0.0
.data 1024 1052 28 2.7
.text 527100 530296 3196 0.6
telink lighting-app tlsr9518adk80d (read/write) 869974 870266 292 0.0
Decreases (5 builds for esp32, linux, qpg, telink)
platform target config section 52d0b42 689bcfa change % change
esp32 all-clusters-app c3devkit (read only) 938950 938946 -4 -0.0
.dram0.data 14276 14268 -8 -0.1
.flash.text 938950 938946 -4 -0.0
linux chip-tool-ipv6only arm64 (read/write) 302305 302289 -16 -0.0
.data.rel.ro 200144 200080 -64 -0.0
thermostat-no-ble arm64 (read/write) 141009 140993 -16 -0.0
.data.rel.ro 74952 74888 -64 -0.1
qpg lock-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
telink lighting-app tlsr9518adk80d text 611380 611378 -2 -0.0
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 52d0b42 689bcfa change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595378 595698 320 0.1
.app_xip_area 500912 501208 296 0.1
.bss 77188 77188 0 0.0
.data 624 648 24 3.8
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 553262 556646 3384 0.6
.app_xip_area 460356 463692 3336 0.7
.bss 75660 75684 24 0.0
.data 588 612 24 4.1
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577294 577610 316 0.1
.app_xip_area 475068 475360 292 0.1
.bss 84652 84652 0 0.0
.data 532 556 24 4.5
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 866356 866636 280 0.0
(read/write) 126684 126708 24 0.0
.bss 124760 124760 0 0.0
.data 1924 1948 24 1.2
.text 866348 866628 280 0.0
BRD4161A+rpc (read only) 853804 854084 280 0.0
(read/write) 143344 143368 24 0.0
.bss 141320 141320 0 0.0
.data 2024 2048 24 1.2
.text 853796 854076 280 0.0
window-app BRD4161A (read only) 838560 838840 280 0.0
(read/write) 125328 125352 24 0.0
.bss 123448 123448 0 0.0
.data 1880 1904 24 1.3
.text 838552 838832 280 0.0
esp32 all-clusters-app c3devkit (read only) 938950 938946 -4 -0.0
(read/write) 1402434 1402714 280 0.0
.dram0.bss 70040 70040 0 0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 199208 199504 296 0.1
.flash.text 938950 938946 -4 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 987139 987151 12 0.0
(read/write) 467444 467732 288 0.1
.dram0.bss 75176 75176 0 0.0
.dram0.data 34040 34064 24 0.1
.flash.rodata 226100 226364 264 0.1
.flash.text 981755 981767 12 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679180 679500 320 0.0
.bss 76632 76632 0 0.0
.data 1884 1908 24 1.3
.text 594864 595160 296 0.0
lock k32w061+release (read/write) 681080 684316 3236 0.5
.bss 76960 76984 24 0.0
.data 1924 1952 28 1.5
.text 596396 599580 3184 0.5
linux chip-tool-ipv6only arm64 (read only) 7409244 7412124 2880 0.0
(read/write) 302305 302289 -16 -0.0
.bss 50641 50641 0 0.0
.data 1176 1224 48 4.1
.data.rel.ro 200144 200080 -64 -0.0
.dynamic 560 560 0 0.0
.got 46552 46552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 399300 399780 480 0.1
.text 6370452 6372884 2432 0.0
thermostat-no-ble arm64 (read only) 2134876 2135212 336 0.0
(read/write) 141009 140993 -16 -0.0
.bss 57953 57953 0 0.0
.data 984 1032 48 4.9
.data.rel.ro 74952 74888 -64 -0.1
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 132316 132604 288 0.2
.text 1784400 1784464 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391184 2391512 328 0.0
.bss 188948 188948 0 0.0
.data 5304 5328 24 0.5
.text 1353784 1354112 328 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2349712 264 0.0
.bss 181000 181000 0 0.0
.data 5600 5624 24 0.4
.text 1312048 1312312 264 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313368 2317672 4304 0.2
.bss 180888 180912 24 0.0
.data 5584 5608 24 0.4
.text 1275968 1280272 4304 0.3
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2303668 328 0.0
.bss 178164 178164 0 0.0
.data 5400 5424 24 0.4
.text 1265912 1266240 328 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005423 1005739 316 0.0
bss 121344 121344 0 0.0
rodata 118268 118544 276 0.2
text 686928 686956 28 0.0
nrf52840dk_nrf52840+rpc (read/write) 974379 974695 316 0.0
bss 118532 118532 0 0.0
rodata 109656 109916 260 0.2
text 666540 666568 28 0.0
nrf52840dongle_nrf52840 (read/write) 1022227 1022543 316 0.0
bss 122708 122708 0 0.0
rodata 117156 117416 260 0.2
text 692496 692524 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 912146 912462 316 0.0
bss 117904 117904 0 0.0
rodata 111524 111784 260 0.2
text 601952 601980 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 937663 940915 3252 0.3
bss 119680 119712 32 0.0
rodata 106668 107752 1084 1.0
text 632844 634860 2016 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 845234 848394 3160 0.4
bss 116276 116304 28 0.0
rodata 99836 100924 1088 1.1
text 548644 550660 2016 0.4
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940035 940355 320 0.0
bss 119432 119432 0 0.0
rodata 106848 107112 264 0.2
text 635088 635120 32 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935375 935695 320 0.0
bss 119436 119436 0 0.0
rodata 106140 106404 264 0.2
text 631124 631156 32 0.0
shell nrf52840dk_nrf52840 (read/write) 803719 803719 0 0.0
bss 111296 111296 0 0.0
rodata 78668 78668 0 0.0
text 536128 536128 0 0.0
qpg lighting-app qpg6105+debug (read only) 586368 586652 284 0.0
(read/write) 146936 146936 0 0.0
.bss 88920 88920 0 0.0
.data 1084 1108 24 2.2
.text 581048 581332 284 0.0
lock-app qpg6105+debug (read only) 532420 535616 3196 0.6
(read/write) 146940 146936 -4 -0.0
.bss 88368 88392 24 0.0
.data 1024 1052 28 2.7
.text 527100 530296 3196 0.6
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 869974 870266 292 0.0
bss 88672 88672 0 0.0
noinit 37160 37160 0 0.0
text 611380 611378 -2 -0.0

@cecille
Fix P6
120f9d6 
Sneaky P6...got by me.
@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR #14845: Size comparison from 52d0b42 to 120f9d6

Increases above 0.2%:

platform target config section 52d0b42 120f9d6 change % change
cyw30739 light cyw930739m2evb_01 .data 624 648 24 3.8
lock cyw930739m2evb_01 (read/write) 553262 556646 3384 0.6
.app_xip_area 460356 463692 3336 0.7
.data 588 612 24 4.1
ota-requestor cyw930739m2evb_01 .data 532 556 24 4.5
efr32 lighting-app BRD4161A .data 1924 1948 24 1.2
BRD4161A+rpc .data 2024 2048 24 1.2
window-app BRD4161A .data 1880 1904 24 1.3
k32w light k32w061+release .data 1884 1908 24 1.3
lock k32w061+release (read/write) 681080 684316 3236 0.5
.data 1924 1952 28 1.5
.text 596396 599580 3184 0.5
linux chip-tool-ipv6only arm64 .data 1176 1224 48 4.1
thermostat-no-ble arm64 .data 984 1032 48 4.9
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5304 5328 24 0.5
lighting-app CY8CPROTO_062_4343W+release .data 5600 5624 24 0.4
lock-app CY8CPROTO_062_4343W+release .data 5584 5608 24 0.4
.text 1275968 1280272 4304 0.3
shell CY8CPROTO_062_4343W+release .data 5400 5424 24 0.4
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 118268 118544 276 0.2
nrf52840dk_nrf52840+rpc rodata 109656 109916 260 0.2
nrf52840dongle_nrf52840 rodata 117156 117416 260 0.2
nrf5340dk_nrf5340_cpuapp rodata 111524 111784 260 0.2
lock-app nrf52840dk_nrf52840 (read/write) 937663 940915 3252 0.3
rodata 106668 107752 1084 1.0
text 632844 634860 2016 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 845234 848394 3160 0.4
rodata 99836 100924 1088 1.1
text 548644 550660 2016 0.4
pump-app nrf52840dk_nrf52840 rodata 106848 107112 264 0.2
pump-controller-app nrf52840dk_nrf52840 rodata 106140 106404 264 0.2
p6 all-clusters-app default .data 2584 2608 24 0.9
light-app default .data 2432 2456 24 1.0
lock-app default .data 2392 2424 32 1.3
.text 1291224 1295136 3912 0.3
qpg lighting-app qpg6105+debug .data 1084 1108 24 2.2
lock-app qpg6105+debug (read only) 532420 535616 3196 0.6
.data 1024 1052 28 2.7
.text 527100 530296 3196 0.6
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 52d0b42 120f9d6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595378 595698 320 0.1
.app_xip_area 500912 501208 296 0.1
.data 624 648 24 3.8
lock cyw930739m2evb_01 (read/write) 553262 556646 3384 0.6
.app_xip_area 460356 463692 3336 0.7
.bss 75660 75684 24 0.0
.data 588 612 24 4.1
ota-requestor cyw930739m2evb_01 (read/write) 577294 577610 316 0.1
.app_xip_area 475068 475360 292 0.1
.data 532 556 24 4.5
efr32 lighting-app BRD4161A (read only) 866356 866636 280 0.0
(read/write) 126684 126708 24 0.0
.data 1924 1948 24 1.2
.text 866348 866628 280 0.0
BRD4161A+rpc (read only) 853804 854084 280 0.0
(read/write) 143344 143368 24 0.0
.data 2024 2048 24 1.2
.text 853796 854076 280 0.0
window-app BRD4161A (read only) 838560 838840 280 0.0
(read/write) 125328 125352 24 0.0
.data 1880 1904 24 1.3
.text 838552 838832 280 0.0
esp32 all-clusters-app c3devkit (read/write) 1402434 1402714 280 0.0
.flash.rodata 199208 199504 296 0.1
m5stack (read only) 987139 987151 12 0.0
(read/write) 467444 467732 288 0.1
.dram0.data 34040 34064 24 0.1
.flash.rodata 226100 226364 264 0.1
.flash.text 981755 981767 12 0.0
k32w light k32w061+release (read/write) 679180 679500 320 0.0
.data 1884 1908 24 1.3
.text 594864 595160 296 0.0
lock k32w061+release (read/write) 681080 684316 3236 0.5
.bss 76960 76984 24 0.0
.data 1924 1952 28 1.5
.text 596396 599580 3184 0.5
linux chip-tool-ipv6only arm64 (read only) 7409244 7411676 2432 0.0
.data 1176 1224 48 4.1
.rodata 399300 399876 576 0.1
.text 6370452 6372388 1936 0.0
thermostat-no-ble arm64 (read only) 2134876 2135212 336 0.0
.data 984 1032 48 4.9
.rodata 132316 132604 288 0.2
.text 1784400 1784464 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2391184 2391512 328 0.0
.data 5304 5328 24 0.5
.text 1353784 1354112 328 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2349448 2349712 264 0.0
.data 5600 5624 24 0.4
.text 1312048 1312312 264 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2313368 2317672 4304 0.2
.bss 180888 180912 24 0.0
.data 5584 5608 24 0.4
.text 1275968 1280272 4304 0.3
shell CY8CPROTO_062_4343W+release (read/write) 2303340 2303668 328 0.0
.data 5400 5424 24 0.4
.text 1265912 1266240 328 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005423 1005739 316 0.0
rodata 118268 118544 276 0.2
text 686928 686956 28 0.0
nrf52840dk_nrf52840+rpc (read/write) 974379 974695 316 0.0
rodata 109656 109916 260 0.2
text 666540 666568 28 0.0
nrf52840dongle_nrf52840 (read/write) 1022227 1022543 316 0.0
rodata 117156 117416 260 0.2
text 692496 692524 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 912146 912462 316 0.0
rodata 111524 111784 260 0.2
text 601952 601980 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 937663 940915 3252 0.3
bss 119680 119712 32 0.0
rodata 106668 107752 1084 1.0
text 632844 634860 2016 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 845234 848394 3160 0.4
bss 116276 116304 28 0.0
rodata 99836 100924 1088 1.1
text 548644 550660 2016 0.4
pump-app nrf52840dk_nrf52840 (read/write) 940035 940355 320 0.0
rodata 106848 107112 264 0.2
text 635088 635120 32 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935375 935695 320 0.0
rodata 106140 106404 264 0.2
text 631124 631156 32 0.0
p6 all-clusters-app default (read/write) 2465624 2465912 288 0.0
.data 2584 2608 24 0.9
.text 1423888 1424176 288 0.0
light-app default (read/write) 2367760 2368040 280 0.0
.data 2432 2456 24 1.0
.text 1326024 1326304 280 0.0
lock-app default (read/write) 2332960 2336872 3912 0.2
.bss 107368 107400 32 0.0
.data 2392 2424 32 1.3
.text 1291224 1295136 3912 0.3
qpg lighting-app qpg6105+debug (read only) 586368 586652 284 0.0
.data 1084 1108 24 2.2
.text 581048 581332 284 0.0
lock-app qpg6105+debug (read only) 532420 535616 3196 0.6
.bss 88368 88392 24 0.0
.data 1024 1052 28 2.7
.text 527100 530296 3196 0.6
telink lighting-app tlsr9518adk80d (read/write) 869974 870266 292 0.0
Decreases (5 builds for esp32, linux, qpg, telink)
platform target config section 52d0b42 120f9d6 change % change
esp32 all-clusters-app c3devkit (read only) 938950 938946 -4 -0.0
.dram0.data 14276 14268 -8 -0.1
.flash.text 938950 938946 -4 -0.0
linux chip-tool-ipv6only arm64 (read/write) 302305 302289 -16 -0.0
.data.rel.ro 200144 200136 -8 -0.0
.got 46552 46496 -56 -0.1
thermostat-no-ble arm64 (read/write) 141009 140993 -16 -0.0
.data.rel.ro 74952 74888 -64 -0.1
qpg lock-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
telink lighting-app tlsr9518adk80d text 611380 611378 -2 -0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 52d0b42 120f9d6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595378 595698 320 0.1
.app_xip_area 500912 501208 296 0.1
.bss 77188 77188 0 0.0
.data 624 648 24 3.8
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 553262 556646 3384 0.6
.app_xip_area 460356 463692 3336 0.7
.bss 75660 75684 24 0.0
.data 588 612 24 4.1
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577294 577610 316 0.1
.app_xip_area 475068 475360 292 0.1
.bss 84652 84652 0 0.0
.data 532 556 24 4.5
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 866356 866636 280 0.0
(read/write) 126684 126708 24 0.0
.bss 124760 124760 0 0.0
.data 1924 1948 24 1.2
.text 866348 866628 280 0.0
BRD4161A+rpc (read only) 853804 854084 280 0.0
(read/write) 143344 143368 24 0.0
.bss 141320 141320 0 0.0
.data 2024 2048 24 1.2
.text 853796 854076 280 0.0
window-app BRD4161A (read only) 838560 838840 280 0.0
(read/write) 125328 125352 24 0.0
.bss 123448 123448 0 0.0
.data 1880 1904 24 1.3
.text 838552 838832 280 0.0
esp32 all-clusters-app c3devkit (read only) 938950 938946 -4 -0.0
(read/write) 1402434 1402714 280 0.0
.dram0.bss 70040 70040 0 0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 199208 199504 296 0.1
.flash.text 938950 938946 -4 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 987139 987151 12 0.0
(read/write) 467444 467732 288 0.1
.dram0.bss 75176 75176 0 0.0
.dram0.data 34040 34064 24 0.1
.flash.rodata 226100 226364 264 0.1
.flash.text 981755 981767 12 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679180 679500 320 0.0
.bss 76632 76632 0 0.0
.data 1884 1908 24 1.3
.text 594864 595160 296 0.0
lock k32w061+release (read/write) 681080 684316 3236 0.5
.bss 76960 76984 24 0.0
.data 1924 1952 28 1.5
.text 596396 599580 3184 0.5
linux chip-tool-ipv6only arm64 (read only) 7409244 7411676 2432 0.0
(read/write) 302305 302289 -16 -0.0
.bss 50641 50641 0 0.0
.data 1176 1224 48 4.1
.data.rel.ro 200144 200136 -8 -0.0
.dynamic 560 560 0 0.0
.got 46552 46496 -56 -0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 399300 399876 576 0.1
.text 6370452 6372388 1936 0.0
thermostat-no-ble arm64 (read only) 2134876 2135212 336 0.0
(read/write) 141009 140993 -16 -0.0
.bss 57953 57953 0 0.0
.data 984 1032 48 4.9
.data.rel.ro 74952 74888 -64 -0.1
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 132316 132604 288 0.2
.text 1784400 1784464 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391184 2391512 328 0.0
.bss 188948 188948 0 0.0
.data 5304 5328 24 0.5
.text 1353784 1354112 328 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2349712 264 0.0
.bss 181000 181000 0 0.0
.data 5600 5624 24 0.4
.text 1312048 1312312 264 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313368 2317672 4304 0.2
.bss 180888 180912 24 0.0
.data 5584 5608 24 0.4
.text 1275968 1280272 4304 0.3
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2303668 328 0.0
.bss 178164 178164 0 0.0
.data 5400 5424 24 0.4
.text 1265912 1266240 328 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1005423 1005739 316 0.0
bss 121344 121344 0 0.0
rodata 118268 118544 276 0.2
text 686928 686956 28 0.0
nrf52840dk_nrf52840+rpc (read/write) 974379 974695 316 0.0
bss 118532 118532 0 0.0
rodata 109656 109916 260 0.2
text 666540 666568 28 0.0
nrf52840dongle_nrf52840 (read/write) 1022227 1022543 316 0.0
bss 122708 122708 0 0.0
rodata 117156 117416 260 0.2
text 692496 692524 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 912146 912462 316 0.0
bss 117904 117904 0 0.0
rodata 111524 111784 260 0.2
text 601952 601980 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 937663 940915 3252 0.3
bss 119680 119712 32 0.0
rodata 106668 107752 1084 1.0
text 632844 634860 2016 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 845234 848394 3160 0.4
bss 116276 116304 28 0.0
rodata 99836 100924 1088 1.1
text 548644 550660 2016 0.4
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940035 940355 320 0.0
bss 119432 119432 0 0.0
rodata 106848 107112 264 0.2
text 635088 635120 32 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935375 935695 320 0.0
bss 119436 119436 0 0.0
rodata 106140 106404 264 0.2
text 631124 631156 32 0.0
shell nrf52840dk_nrf52840 (read/write) 803719 803719 0 0.0
bss 111296 111296 0 0.0
rodata 78668 78668 0 0.0
text 536128 536128 0 0.0
p6 all-clusters-app default (read/write) 2465624 2465912 288 0.0
.bss 118560 118560 0 0.0
.data 2584 2608 24 0.9
.text 1423888 1424176 288 0.0
light-app default (read/write) 2367760 2368040 280 0.0
.bss 107664 107664 0 0.0
.data 2432 2456 24 1.0
.text 1326024 1326304 280 0.0
lock-app default (read/write) 2332960 2336872 3912 0.2
.bss 107368 107400 32 0.0
.data 2392 2424 32 1.3
.text 1291224 1295136 3912 0.3
qpg lighting-app qpg6105+debug (read only) 586368 586652 284 0.0
(read/write) 146936 146936 0 0.0
.bss 88920 88920 0 0.0
.data 1084 1108 24 2.2
.text 581048 581332 284 0.0
lock-app qpg6105+debug (read only) 532420 535616 3196 0.6
(read/write) 146940 146936 -4 -0.0
.bss 88368 88392 24 0.0
.data 1024 1052 28 2.7
.text 527100 530296 3196 0.6
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 869974 870266 292 0.0
bss 88672 88672 0 0.0
noinit 37160 37160 0 0.0
text 611380 611378 -2 -0.0

@bzbarsky-apple
Copy link
Contributor

/rebase

@cecille cecille force-pushed the dac_fixup_for_pid_vid_change branch from 7df431a to 1c8196e Compare February 9, 2022 14:30
@github-actions
Copy link

github-actions bot commented Feb 9, 2022 •
edited
Loading

PR #14845: Size comparison from 45b2690 to 1c8196e

Increases above 0.2%:

platform target config section 45b2690 1c8196e change % change
cyw30739 light cyw930739m2evb_01 .data 624 648 24 3.8
lock cyw930739m2evb_01 .data 588 612 24 4.1
ota-requestor cyw930739m2evb_01 .data 532 556 24 4.5
efr32 lighting-app BRD4161A .data 2008 2032 24 1.2
BRD4161A+rpc .data 2108 2132 24 1.1
window-app BRD4161A .data 1880 1904 24 1.3
k32w light k32w061+release .data 1884 1908 24 1.3
lock k32w061+release .data 1928 1952 24 1.2
linux chip-tool-ipv6only arm64 .data 1176 1224 48 4.1
thermostat-no-ble arm64 .data 984 1032 48 4.9
.rodata 132108 132396 288 0.2
p6 all-clusters-app default .data 2632 2656 24 0.9
light-app default .data 2496 2520 24 1.0
lock-app default .data 2464 2488 24 1.0
qpg lighting-app qpg6105+debug .data 1084 1108 24 2.2
lock-app qpg6105+debug .data 1028 1052 24 2.3
Increases (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 45b2690 1c8196e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595374 595694 320 0.1
.app_xip_area 500908 501204 296 0.1
.data 624 648 24 3.8
lock cyw930739m2evb_01 (read/write) 556326 556642 316 0.1
.app_xip_area 463396 463688 292 0.1
.data 588 612 24 4.1
ota-requestor cyw930739m2evb_01 (read/write) 577226 577542 316 0.1
.app_xip_area 475048 475340 292 0.1
.data 532 556 24 4.5
efr32 lighting-app BRD4161A (read only) 898448 898728 280 0.0
(read/write) 127264 127288 24 0.0
.data 2008 2032 24 1.2
.text 898440 898720 280 0.0
BRD4161A+rpc (read only) 885884 886164 280 0.0
(read/write) 143924 143948 24 0.0
.data 2108 2132 24 1.1
.text 885876 886156 280 0.0
window-app BRD4161A (read only) 838752 839032 280 0.0
(read/write) 125328 125352 24 0.0
.data 1880 1904 24 1.3
.text 838744 839024 280 0.0
k32w light k32w061+release (read/write) 679116 679436 320 0.0
.data 1884 1908 24 1.3
.text 594848 595144 296 0.0
lock k32w061+release (read/write) 683996 684316 320 0.0
.data 1928 1952 24 1.2
.text 599284 599580 296 0.0
linux chip-tool-ipv6only arm64 (read only) 7390428 7393308 2880 0.0
.data 1176 1224 48 4.1
.rodata 397252 397732 480 0.1
.text 6355892 6358324 2432 0.0
thermostat-no-ble arm64 (read only) 2131052 2131372 320 0.0
.data 984 1032 48 4.9
.rodata 132108 132396 288 0.2
.text 1780880 1780928 48 0.0
p6 all-clusters-app default (read/write) 2476616 2476904 288 0.0
.data 2632 2656 24 0.9
.text 1434880 1435168 288 0.0
light-app default (read/write) 2380312 2380592 280 0.0
.data 2496 2520 24 1.0
.text 1338576 1338856 280 0.0
lock-app default (read/write) 2349136 2349424 288 0.0
.data 2464 2488 24 1.0
.text 1307400 1307688 288 0.0
qpg lighting-app qpg6105+debug (read only) 586320 586612 292 0.0
.data 1084 1108 24 2.2
.text 581000 581292 292 0.1
lock-app qpg6105+debug (read only) 535316 535608 292 0.1
.data 1028 1052 24 2.3
.text 529996 530288 292 0.1
telink lighting-app tlsr9518adk80d (read/write) 866774 867066 292 0.0
Decreases (3 builds for linux, telink)
platform target config section 45b2690 1c8196e change % change
linux chip-tool-ipv6only arm64 (read/write) 301313 301297 -16 -0.0
.data.rel.ro 199304 199240 -64 -0.0
thermostat-no-ble arm64 (read/write) 140673 140657 -16 -0.0
.data.rel.ro 74904 74840 -64 -0.1
telink lighting-app tlsr9518adk80d text 608368 608366 -2 -0.0
Full report (17 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 45b2690 1c8196e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595374 595694 320 0.1
.app_xip_area 500908 501204 296 0.1
.bss 77188 77188 0 0.0
.data 624 648 24 3.8
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556326 556642 316 0.1
.app_xip_area 463396 463688 292 0.1
.bss 75684 75684 0 0.0
.data 588 612 24 4.1
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577226 577542 316 0.1
.app_xip_area 475048 475340 292 0.1
.bss 84604 84604 0 0.0
.data 532 556 24 4.5
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 898448 898728 280 0.0
(read/write) 127264 127288 24 0.0
.bss 125256 125256 0 0.0
.data 2008 2032 24 1.2
.text 898440 898720 280 0.0
BRD4161A+rpc (read only) 885884 886164 280 0.0
(read/write) 143924 143948 24 0.0
.bss 141816 141816 0 0.0
.data 2108 2132 24 1.1
.text 885876 886156 280 0.0
window-app BRD4161A (read only) 838752 839032 280 0.0
(read/write) 125328 125352 24 0.0
.bss 123448 123448 0 0.0
.data 1880 1904 24 1.3
.text 838744 839024 280 0.0
k32w light k32w061+release (read/write) 679116 679436 320 0.0
.bss 76584 76584 0 0.0
.data 1884 1908 24 1.3
.text 594848 595144 296 0.0
lock k32w061+release (read/write) 683996 684316 320 0.0
.bss 76984 76984 0 0.0
.data 1928 1952 24 1.2
.text 599284 599580 296 0.0
linux chip-tool-ipv6only arm64 (read only) 7390428 7393308 2880 0.0
(read/write) 301313 301297 -16 -0.0
.bss 50641 50641 0 0.0
.data 1176 1224 48 4.1
.data.rel.ro 199304 199240 -64 -0.0
.dynamic 560 560 0 0.0
.got 46400 46400 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 397252 397732 480 0.1
.text 6355892 6358324 2432 0.0
thermostat-no-ble arm64 (read only) 2131052 2131372 320 0.0
(read/write) 140673 140657 -16 -0.0
.bss 57665 57665 0 0.0
.data 984 1032 48 4.9
.data.rel.ro 74904 74840 -64 -0.1
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132108 132396 288 0.2
.text 1780880 1780928 48 0.0
p6 all-clusters-app default (read/write) 2476616 2476904 288 0.0
.bss 117656 117656 0 0.0
.data 2632 2656 24 0.9
.text 1434880 1435168 288 0.0
light-app default (read/write) 2380312 2380592 280 0.0
.bss 107296 107296 0 0.0
.data 2496 2520 24 1.0
.text 1338576 1338856 280 0.0
lock-app default (read/write) 2349136 2349424 288 0.0
.bss 107040 107040 0 0.0
.data 2464 2488 24 1.0
.text 1307400 1307688 288 0.0
qpg lighting-app qpg6105+debug (read only) 586320 586612 292 0.0
(read/write) 146936 146936 0 0.0
.bss 88872 88872 0 0.0
.data 1084 1108 24 2.2
.text 581000 581292 292 0.1
lock-app qpg6105+debug (read only) 535316 535608 292 0.1
(read/write) 146936 146936 0 0.0
.bss 88392 88392 0 0.0
.data 1028 1052 24 2.3
.text 529996 530288 292 0.1
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 866774 867066 292 0.0
bss 88664 88664 0 0.0
noinit 37160 37160 0 0.0
text 608368 608366 -2 -0.0

@boring-cyborg boring-cyborg bot added the github label Feb 9, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2022 •
edited
Loading

PR #14845: Size comparison from 45b2690 to dadb108

Increases above 0.2%:

platform target config section 45b2690 dadb108 change % change
cyw30739 light cyw930739m2evb_01 .data 624 648 24 3.8
lock cyw930739m2evb_01 .data 588 612 24 4.1
ota-requestor cyw930739m2evb_01 .data 532 556 24 4.5
efr32 lighting-app BRD4161A .data 2008 2032 24 1.2
BRD4161A+rpc .data 2108 2132 24 1.1
window-app BRD4161A .data 1880 1904 24 1.3
k32w light k32w061+release .data 1884 1908 24 1.3
lock k32w061+release .data 1928 1952 24 1.2
linux all-clusters-app debug (read only) 2329273 2335297 6024 0.3
.data 1168 1216 48 4.1
.rodata 204453 204933 480 0.2
.text 1962594 1968114 5520 0.3
bridge-app debug+rpc .data 1970 2034 64 3.2
.rodata 140332 140620 288 0.2
chip-tool debug (read only) 7466349 7515349 49000 0.7
.data 1152 1200 48 4.2
.rodata 414773 419285 4512 1.1
.text 6651141 6695653 44512 0.7
chip-tool-ipv6only arm64 (read only) 7390428 7434284 43856 0.6
.data 1176 1224 48 4.1
.got 46400 47008 608 1.3
.rodata 397252 401652 4400 1.1
.text 6355892 6393556 37664 0.6
door-lock-app debug .data 946 1010 64 6.8
lighting-app debug+rpc .data 1368 1432 64 4.7
ota-provider-app debug .data 1160 1192 32 2.8
ota-requestor-app debug .data 1128 1160 32 2.8
.rodata 145495 145815 320 0.2
shell debug (read only) 2302729 2308705 5976 0.3
.data 768 816 48 6.2
.rodata 205170 205618 448 0.2
.text 1941138 1946642 5504 0.3
thermostat-no-ble arm64 .data 984 1032 48 4.9
tv-app debug .data 3168 3200 32 1.0
.rodata 196140 196652 512 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5280 5304 24 0.5
lighting-app CY8CPROTO_062_4343W+release .data 5600 5624 24 0.4
lock-app CY8CPROTO_062_4343W+release .data 5584 5608 24 0.4
shell CY8CPROTO_062_4343W+release .data 5400 5424 24 0.4
nrfconnect lock-app nrf5340dk_nrf5340_cpuapp rodata 100708 100968 260 0.3
p6 all-clusters-app default .data 2632 2656 24 0.9
light-app default .data 2496 2520 24 1.0
lock-app default .data 2464 2488 24 1.0
qpg lighting-app qpg6105+debug .data 1084 1108 24 2.2
lock-app qpg6105+debug .data 1028 1052 24 2.3
Increases (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 45b2690 dadb108 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595374 595694 320 0.1
.app_xip_area 500908 501204 296 0.1
.data 624 648 24 3.8
lock cyw930739m2evb_01 (read/write) 556326 556642 316 0.1
.app_xip_area 463396 463688 292 0.1
.data 588 612 24 4.1
ota-requestor cyw930739m2evb_01 (read/write) 577226 577542 316 0.1
.app_xip_area 475048 475340 292 0.1
.data 532 556 24 4.5
efr32 lighting-app BRD4161A (read only) 898448 898728 280 0.0
(read/write) 127264 127288 24 0.0
.data 2008 2032 24 1.2
.text 898440 898720 280 0.0
BRD4161A+rpc (read only) 885884 886164 280 0.0
(read/write) 143924 143948 24 0.0
.data 2108 2132 24 1.1
.text 885876 886156 280 0.0
window-app BRD4161A (read only) 838752 839328 576 0.1
(read/write) 125328 125384 56 0.0
.bss 123448 123480 32 0.0
.data 1880 1904 24 1.3
.text 838744 839320 576 0.1
esp32 all-clusters-app c3devkit (read only) 938970 940822 1852 0.2
(read/write) 1397658 1398146 488 0.0
.dram0.bss 66328 66344 16 0.0
.flash.rodata 198160 198648 488 0.2
.flash.text 938970 940822 1852 0.2
m5stack (read only) 987163 988779 1616 0.2
(read/write) 462680 463168 488 0.1
.dram0.bss 71472 71488 16 0.0
.dram0.data 34024 34048 24 0.1
.flash.rodata 225056 225504 448 0.2
.flash.text 981779 983395 1616 0.2
k32w light k32w061+release (read/write) 679116 679436 320 0.0
.data 1884 1908 24 1.3
.text 594848 595144 296 0.0
lock k32w061+release (read/write) 683996 684316 320 0.0
.data 1928 1952 24 1.2
.text 599284 599580 296 0.0
linux all-clusters-app debug (read only) 2329273 2335297 6024 0.3
(read/write) 140032 140064 32 0.0
.bss 54656 54688 32 0.1
.data 1168 1216 48 4.1
.rodata 204453 204933 480 0.2
.text 1962594 1968114 5520 0.3
bridge-app debug+rpc (read only) 1705829 1706157 328 0.0
.data 1970 2034 64 3.2
.rodata 140332 140620 288 0.2
.text 1448949 1449013 64 0.0
chip-tool debug (read only) 7466349 7515349 49000 0.7
.data 1152 1200 48 4.2
.rodata 414773 419285 4512 1.1
.text 6651141 6695653 44512 0.7
chip-tool-ipv6only arm64 (read only) 7390428 7434284 43856 0.6
(read/write) 301313 301905 592 0.2
.data 1176 1224 48 4.1
.got 46400 47008 608 1.3
.rodata 397252 401652 4400 1.1
.text 6355892 6393556 37664 0.6
door-lock-app debug (read only) 1910537 1910865 328 0.0
.data 946 1010 64 6.8
.rodata 171858 172146 288 0.2
.text 1590162 1590226 64 0.0
lighting-app debug+rpc (read only) 2005097 2005409 312 0.0
.data 1368 1432 64 4.7
.rodata 163057 163345 288 0.2
.text 1687394 1687442 48 0.0
ota-provider-app debug (read only) 1714521 1714833 312 0.0
.data 1160 1192 32 2.8
.rodata 151910 152198 288 0.2
.text 1443906 1443954 48 0.0
ota-requestor-app debug (read only) 1709145 1709505 360 0.0
.data 1128 1160 32 2.8
.rodata 145495 145815 320 0.2
.text 1446754 1446818 64 0.0
shell debug (read only) 2302729 2308705 5976 0.3
(read/write) 141584 141648 64 0.0
.bss 62048 62080 32 0.1
.data 768 816 48 6.2
.rodata 205170 205618 448 0.2
.text 1941138 1946642 5504 0.3
thermostat-no-ble arm64 (read only) 2131052 2131372 320 0.0
.data 984 1032 48 4.9
.rodata 132108 132396 288 0.2
.text 1780880 1780928 48 0.0
tv-app debug (read only) 2503193 2506225 3032 0.1
.bss 57280 57312 32 0.1
.data 3168 3200 32 1.0
.rodata 196140 196652 512 0.3
.text 2134114 2136658 2544 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2389944 2391800 1856 0.1
.bss 188404 188412 8 0.0
.data 5280 5304 24 0.5
.text 1352544 1354400 1856 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2349448 2349712 264 0.0
.data 5600 5624 24 0.4
.text 1312048 1312312 264 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2317408 2317672 264 0.0
.data 5584 5608 24 0.4
.text 1280008 1280272 264 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2303340 2303668 328 0.0
.data 5400 5424 24 0.4
.text 1265912 1266240 328 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1006427 1006763 336 0.0
rodata 118312 118592 280 0.2
text 687896 687924 28 0.0
nrf52840dk_nrf52840+rpc (read/write) 975271 975587 316 0.0
rodata 109700 109960 260 0.2
text 667512 667540 28 0.0
nrf52840dongle_nrf52840 (read/write) 1022383 1022703 320 0.0
rodata 117200 117464 264 0.2
text 692608 692636 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 913138 913454 316 0.0
rodata 111572 111832 260 0.2
text 602924 602952 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 940775 941075 300 0.0
rodata 107540 107800 260 0.2
text 634944 634972 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848234 848550 316 0.0
rodata 100708 100968 260 0.3
text 550744 550772 28 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940195 940511 316 0.0
rodata 106896 107156 260 0.2
text 635200 635232 32 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935535 935851 316 0.0
rodata 106188 106448 260 0.2
text 631236 631268 32 0.0
p6 all-clusters-app default (read/write) 2476616 2478848 2232 0.1
.bss 117656 117672 16 0.0
.data 2632 2656 24 0.9
.text 1434880 1437112 2232 0.2
light-app default (read/write) 2380312 2380592 280 0.0
.data 2496 2520 24 1.0
.text 1338576 1338856 280 0.0
lock-app default (read/write) 2349136 2349424 288 0.0
.data 2464 2488 24 1.0
.text 1307400 1307688 288 0.0
qpg lighting-app qpg6105+debug (read only) 586320 586612 292 0.0
.data 1084 1108 24 2.2
.text 581000 581292 292 0.1
lock-app qpg6105+debug (read only) 535316 535608 292 0.1
.data 1028 1052 24 2.3
.text 529996 530288 292 0.1
telink lighting-app tlsr9518adk80d (read/write) 866774 867066 292 0.0
Decreases (13 builds for esp32, linux, telink)
platform target config section 45b2690 dadb108 change % change
esp32 all-clusters-app c3devkit .dram0.data 14260 14252 -8 -0.1
linux all-clusters-app debug .data.rel.ro 78536 78488 -48 -0.1
bridge-app debug+rpc .data.rel.ro 38120 38056 -64 -0.2
chip-tool debug .data.rel.ro 157624 157560 -64 -0.0
chip-tool-ipv6only arm64 .data.rel.ro 199304 199240 -64 -0.0
door-lock-app debug (read/write) 110680 110648 -32 -0.0
.data.rel.ro 62160 62064 -96 -0.2
lighting-app debug+rpc (read/write) 115632 115600 -32 -0.0
.data.rel.ro 65672 65576 -96 -0.1
ota-provider-app debug (read/write) 81368 81304 -64 -0.1
.data.rel.ro 33560 33464 -96 -0.3
ota-requestor-app debug (read/write) 83288 83224 -64 -0.1
.data.rel.ro 34616 34520 -96 -0.3
shell debug .data.rel.ro 73072 73040 -32 -0.0
thermostat-no-ble arm64 (read/write) 140673 140657 -16 -0.0
.data.rel.ro 74904 74840 -64 -0.1
tv-app debug .data.rel.ro 73048 72984 -64 -0.1
telink lighting-app tlsr9518adk80d text 608368 608366 -2 -0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 45b2690 dadb108 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595374 595694 320 0.1
.app_xip_area 500908 501204 296 0.1
.bss 77188 77188 0 0.0
.data 624 648 24 3.8
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556326 556642 316 0.1
.app_xip_area 463396 463688 292 0.1
.bss 75684 75684 0 0.0
.data 588 612 24 4.1
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577226 577542 316 0.1
.app_xip_area 475048 475340 292 0.1
.bss 84604 84604 0 0.0
.data 532 556 24 4.5
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 898448 898728 280 0.0
(read/write) 127264 127288 24 0.0
.bss 125256 125256 0 0.0
.data 2008 2032 24 1.2
.text 898440 898720 280 0.0
BRD4161A+rpc (read only) 885884 886164 280 0.0
(read/write) 143924 143948 24 0.0
.bss 141816 141816 0 0.0
.data 2108 2132 24 1.1
.text 885876 886156 280 0.0
window-app BRD4161A (read only) 838752 839328 576 0.1
(read/write) 125328 125384 56 0.0
.bss 123448 123480 32 0.0
.data 1880 1904 24 1.3
.text 838744 839320 576 0.1
esp32 all-clusters-app c3devkit (read only) 938970 940822 1852 0.2
(read/write) 1397658 1398146 488 0.0
.dram0.bss 66328 66344 16 0.0
.dram0.data 14260 14252 -8 -0.1
.flash.rodata 198160 198648 488 0.2
.flash.text 938970 940822 1852 0.2
.iram0.text 62056 62056 0 0.0
m5stack (read only) 987163 988779 1616 0.2
(read/write) 462680 463168 488 0.1
.dram0.bss 71472 71488 16 0.0
.dram0.data 34024 34048 24 0.1
.flash.rodata 225056 225504 448 0.2
.flash.text 981779 983395 1616 0.2
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 679116 679436 320 0.0
.bss 76584 76584 0 0.0
.data 1884 1908 24 1.3
.text 594848 595144 296 0.0
lock k32w061+release (read/write) 683996 684316 320 0.0
.bss 76984 76984 0 0.0
.data 1928 1952 24 1.2
.text 599284 599580 296 0.0
linux all-clusters-app debug (read only) 2329273 2335297 6024 0.3
(read/write) 140032 140064 32 0.0
.bss 54656 54688 32 0.1
.data 1168 1216 48 4.1
.data.rel.ro 78536 78488 -48 -0.1
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204453 204933 480 0.2
.text 1962594 1968114 5520 0.3
bridge-app debug+rpc (read only) 1705829 1706157 328 0.0
(read/write) 84328 84328 0 0.0
.bss 39088 39088 0 0.0
.data 1970 2034 64 3.2
.data.rel.ro 38120 38056 -64 -0.2
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140332 140620 288 0.2
.text 1448949 1449013 64 0.0
chip-tool debug (read only) 7466349 7515349 49000 0.7
(read/write) 197176 197176 0 0.0
.bss 32360 32360 0 0.0
.data 1152 1200 48 4.2
.data.rel.ro 157624 157560 -64 -0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 414773 419285 4512 1.1
.text 6651141 6695653 44512 0.7
chip-tool-ipv6only arm64 (read only) 7390428 7434284 43856 0.6
(read/write) 301313 301905 592 0.2
.bss 50641 50641 0 0.0
.data 1176 1224 48 4.1
.data.rel.ro 199304 199240 -64 -0.0
.dynamic 560 560 0 0.0
.got 46400 47008 608 1.3
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 397252 401652 4400 1.1
.text 6355892 6393556 37664 0.6
door-lock-app debug (read only) 1910537 1910865 328 0.0
(read/write) 110680 110648 -32 -0.0
.bss 42160 42160 0 0.0
.data 946 1010 64 6.8
.data.rel.ro 62160 62064 -96 -0.2
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171858 172146 288 0.2
.text 1590162 1590226 64 0.0
lighting-app debug+rpc (read only) 2005097 2005409 312 0.0
(read/write) 115632 115600 -32 -0.0
.bss 43104 43104 0 0.0
.data 1368 1432 64 4.7
.data.rel.ro 65672 65576 -96 -0.1
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 163057 163345 288 0.2
.text 1687394 1687442 48 0.0
ota-provider-app debug (read only) 1714521 1714833 312 0.0
(read/write) 81368 81304 -64 -0.1
.bss 41120 41120 0 0.0
.data 1160 1192 32 2.8
.data.rel.ro 33560 33464 -96 -0.3
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151910 152198 288 0.2
.text 1443906 1443954 48 0.0
ota-requestor-app debug (read only) 1709145 1709505 360 0.0
(read/write) 83288 83224 -64 -0.1
.bss 42240 42240 0 0.0
.data 1128 1160 32 2.8
.data.rel.ro 34616 34520 -96 -0.3
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 145495 145815 320 0.2
.text 1446754 1446818 64 0.0
shell debug (read only) 2302729 2308705 5976 0.3
(read/write) 141584 141648 64 0.0
.bss 62048 62080 32 0.1
.data 768 816 48 6.2
.data.rel.ro 73072 73040 -32 -0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205170 205618 448 0.2
.text 1941138 1946642 5504 0.3
thermostat-no-ble arm64 (read only) 2131052 2131372 320 0.0
(read/write) 140673 140657 -16 -0.0
.bss 57665 57665 0 0.0
.data 984 1032 48 4.9
.data.rel.ro 74904 74840 -64 -0.1
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132108 132396 288 0.2
.text 1780880 1780928 48 0.0
tv-app debug (read only) 2503193 2506225 3032 0.1
(read/write) 139512 139512 0 0.0
.bss 57280 57312 32 0.1
.data 3168 3200 32 1.0
.data.rel.ro 73048 72984 -64 -0.1
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 196140 196652 512 0.3
.text 2134114 2136658 2544 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389944 2391800 1856 0.1
.bss 188404 188412 8 0.0
.data 5280 5304 24 0.5
.text 1352544 1354400 1856 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349448 2349712 264 0.0
.bss 181000 181000 0 0.0
.data 5600 5624 24 0.4
.text 1312048 1312312 264 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317408 2317672 264 0.0
.bss 180912 180912 0 0.0
.data 5584 5608 24 0.4
.text 1280008 1280272 264 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303340 2303668 328 0.0
.bss 178164 178164 0 0.0
.data 5400 5424 24 0.4
.text 1265912 1266240 328 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1006427 1006763 336 0.0
bss 121320 121320 0 0.0
rodata 118312 118592 280 0.2
text 687896 687924 28 0.0
nrf52840dk_nrf52840+rpc (read/write) 975271 975587 316 0.0
bss 118508 118508 0 0.0
rodata 109700 109960 260 0.2
text 667512 667540 28 0.0
nrf52840dongle_nrf52840 (read/write) 1022383 1022703 320 0.0
bss 122716 122716 0 0.0
rodata 117200 117464 264 0.2
text 692608 692636 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 913138 913454 316 0.0
bss 117880 117880 0 0.0
rodata 111572 111832 260 0.2
text 602924 602952 28 0.0
lock-app nrf52840dk_nrf52840 (read/write) 940775 941075 300 0.0
bss 119720 119720 0 0.0
rodata 107540 107800 260 0.2
text 634944 634972 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848234 848550 316 0.0
bss 116312 116312 0 0.0
rodata 100708 100968 260 0.3
text 550744 550772 28 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 940195 940511 316 0.0
bss 119440 119440 0 0.0
rodata 106896 107156 260 0.2
text 635200 635232 32 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 935535 935851 316 0.0
bss 119444 119444 0 0.0
rodata 106188 106448 260 0.2
text 631236 631268 32 0.0
shell nrf52840dk_nrf52840 (read/write) 803911 803911 0 0.0
bss 111304 111304 0 0.0
rodata 78716 78716 0 0.0
text 536272 536272 0 0.0
p6 all-clusters-app default (read/write) 2476616 2478848 2232 0.1
.bss 117656 117672 16 0.0
.data 2632 2656 24 0.9
.text 1434880 1437112 2232 0.2
light-app default (read/write) 2380312 2380592 280 0.0
.bss 107296 107296 0 0.0
.data 2496 2520 24 1.0
.text 1338576 1338856 280 0.0
lock-app default (read/write) 2349136 2349424 288 0.0
.bss 107040 107040 0 0.0
.data 2464 2488 24 1.0
.text 1307400 1307688 288 0.0
qpg lighting-app qpg6105+debug (read only) 586320 586612 292 0.0
(read/write) 146936 146936 0 0.0
.bss 88872 88872 0 0.0
.data 1084 1108 24 2.2
.text 581000 581292 292 0.1
lock-app qpg6105+debug (read only) 535316 535608 292 0.1
(read/write) 146936 146936 0 0.0
.bss 88392 88392 0 0.0
.data 1028 1052 24 2.3
.text 529996 530288 292 0.1
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 866774 867066 292 0.0
bss 88664 88664 0 0.0
noinit 37160 37160 0 0.0
text 608368 608366 -2 -0.0

@andy31415 andy31415 merged commit 482e6fd into project-chip:master Feb 9, 2022
@cecille cecille deleted the dac_fixup_for_pid_vid_change branch February 11, 2022 15:42
cecille added a commit to cecille/connectedhomeip that referenced this pull request Feb 11, 2022
@cecille
Consolidate dac verification parameters into struct.
3544e69 
Per request in project-chip#14845, issue project-chip#14758
@cecille cecille mentioned this pull request Feb 11, 2022
Merged
bzbarsky-apple pushed a commit that referenced this pull request Feb 17, 2022
@cecille
Consolidate dac verification parameters into struct. (#15090)
b541dee 
* Consolidate dac verification parameters into struct.

Per request in #14845, issue #14758

* make struct not use references.

* Fix up some naming.
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this pull request Apr 26, 2022
@cecille @fuxingguo16
Consolidate dac verification parameters into struct. (project-chip#15090
abebb45 
)

* Consolidate dac verification parameters into struct.

Per request in project-chip#14845, issue project-chip#14758

* make struct not use references.

* Fix up some naming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@emargolis emargolis emargolis approved these changes

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
config github review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cecille @emargolis @jmartinez-silabs @bzbarsky-apple @tcarmelveilleux @andy31415 @restyled-commits